Skip to content

Conversation

@Fisiu
Copy link
Contributor

@Fisiu Fisiu commented May 6, 2018

Signed-off-by: Mariusz Fik [email protected]

@nWidart
Copy link
Member

nWidart commented May 6, 2018

Wouldn't it be best to rename the field in the view to also use is_activated instead? Which keeps the clarity that the variable is a boolean.

@Fisiu
Copy link
Contributor Author

Fisiu commented May 6, 2018

Hmm, but where to do so? I tried to update view and mode in Modules/User/Assets/js/components/UserForm.vue then compiled it by running:

npm dev

and

php artisan module:publish User

However request still passes activated property instead of is_activated. No idea what I'm missing...

@Fisiu
Copy link
Contributor Author

Fisiu commented May 6, 2018

I finally found root cause, a FullUserTransformer class ;-)
PR updated.

@nWidart
Copy link
Member

nWidart commented May 18, 2018

Does this work because I see the vue components use an activated key?

@Fisiu
Copy link
Contributor Author

Fisiu commented Jun 10, 2018

I missed vue component in commit ;-)

@nWidart
Copy link
Member

nWidart commented Jun 21, 2018

Thank you.

@nWidart nWidart merged commit 10757e4 into AsgardCms:3.0 Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants