Skip to content

custom backend editor fix #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nWidart merged 1 commit into from
Apr 19, 2018
Merged

custom backend editor fix #513

nWidart merged 1 commit into from
Apr 19, 2018

Conversation

@superewald
Copy link
Contributor

@superewald superewald commented Apr 4, 2018

The ActiveEditor.js doesn't refuse to load a custom editor anymore (Bugfix for #506).

@superewald
custom backend editor fixes
1eb8547 
The ActiveEditor.js doesn't refuse to load a custom editor anymore.
@nWidart
Copy link
Member

nWidart commented Apr 4, 2018

Thanks. I'm not sure I understand why configuredEditor would ever be undefined as this is returned by the hook.

@superewald
Copy link
Contributor Author

superewald commented Apr 5, 2018

I was curious about the default "ckeditor" return. Thought it may be some guard for missing definition of window.AsgardCMS.Editor.
You can of course remove that check if it wasn't intended at all.
(Hope I did right so you can edit this PR - it's actually my first one).

@nWidart
Copy link
Member

nWidart commented Apr 19, 2018

sorry for late reply, thank you for the contribution! 👍 🎉

@nWidart nWidart merged commit 22ccee9 into AsgardCms:3.0 Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@superewald @nWidart