Make all Perl warnings fatal

There are a lot of Perl scripts in the tree, mostly code generation
and TAP tests.  Occasionally, these scripts produce warnings.  These
are probably always mistakes on the developer side (true positives).
Typical examples are warnings from genbki.pl or related when you make
a mess in the catalog files during development, or warnings from tests
when they massage a config file that looks different on different
hosts, or mistakes during merges (e.g., duplicate subroutine
definitions), or just mistakes that weren't noticed because there is a
lot of output in a verbose build.

This changes all warnings into fatal errors, by replacing

    use warnings;

by

    use warnings FATAL => 'all';

in all Perl files.

Discussion: https://www.postgresql.org/message-id/flat/06f899fd-1826-05ab-42d6-adeb1fd5e200%40eisentraut.org

Author: petere

config/check_modules.pl

@@ -5,7 +5,7 @@
 # but specify them anyway for documentation's sake.)
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Config;
 
 use IPC::Run 0.79;

contrib/amcheck/t/001_verify_heapam.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/amcheck/t/002_cic.pl

@@ -3,7 +3,7 @@
 
 # Test CREATE INDEX CONCURRENTLY with concurrent modifications
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/amcheck/t/003_cic_2pc.pl

@@ -3,7 +3,7 @@
 
 # Test CREATE INDEX CONCURRENTLY with concurrent prepared-xact modifications
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/amcheck/t/004_verify_nbtree_unique.pl

@@ -5,7 +5,7 @@
 # presence of breaking sort order changes.
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/amcheck/t/005_pitr.pl

@@ -2,7 +2,7 @@
 
 # Test integrity of intermediate states by PITR to those states
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/auto_explain/t/001_auto_explain.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/basebackup_to_shell/t/001_basic.pl

@@ -1,7 +1,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/bloom/t/001_wal.pl

@@ -3,7 +3,7 @@
 
 # Test generic xlog record work for bloom index replication.
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/fuzzystrmatch/daitch_mokotoff_header.pl

@@ -9,7 +9,7 @@
 #
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 die "Usage: $0 OUTPUT_FILE\n" if @ARGV != 1;
 my $output_file = $ARGV[0];