pgcommitfest2.git
3 months agoRevert "Include patch id in commitfest page" master
Magnus Hagander [Sat, 11 Jan 2025 12:48:32 +0000 (13:48 +0100)]
Revert "Include patch id in commitfest page"

This reverts commit eee60a5332ac0745071086477ff4e189b080d3ab.

Discussion: https://postgr.es/m/ff9d7921-f4e3-498a-9dba-ddd28fdb359f%40eisentraut.org

3 months agoInclude patch id in commitfest page
Jelte Fennema-Nio [Mon, 23 Dec 2024 22:43:02 +0000 (23:43 +0100)]
Include patch id in commitfest page

Clicking the patch header would sort by the patch ID, but that ID would
not actually be visible. Effectively resulting in random ordering for
the user, so let's just show the ID.

3 months agoAdd note about pre-commit hook
Jelte Fennema-Nio [Thu, 19 Dec 2024 19:21:35 +0000 (20:21 +0100)]
Add note about pre-commit hook

4 months agoAdd missing setup.cfg
Magnus Hagander [Fri, 20 Dec 2024 22:25:32 +0000 (23:25 +0100)]
Add missing setup.cfg

Seems I forgot to git add this ages ago :/

Spotted by Jelte Fennema-Nio

4 months agoUpdate django in requirements.txt to be 4.2
Magnus Hagander [Thu, 19 Dec 2024 16:10:08 +0000 (17:10 +0100)]
Update django in requirements.txt to be 4.2

We've been running 4.2 in production for a long time by now, but forgot
to update the requirements.txt file. Oops...

4 months agoAdd LICENSE file
Magnus Hagander [Wed, 18 Dec 2024 11:36:37 +0000 (12:36 +0100)]
Add LICENSE file

We use the PostgreSQL license, lets make it explicit.

Spotted by Jelte Fennema-Nio

4 months agoDOn't crash on very long annotations
Magnus Hagander [Tue, 10 Dec 2024 12:09:10 +0000 (13:09 +0100)]
DOn't crash on very long annotations

When a very long annotation is posted, we would crash if it's shorter
than 500 characters, but the length of the *log* message became longer
than 500. To handle this, shorten the text in the log message if it's
too long.

7 months agoMinor pycodestyle updates
Magnus Hagander [Tue, 24 Sep 2024 20:31:28 +0000 (22:31 +0200)]
Minor pycodestyle updates

7 months agoAllow searching by email Message-ID
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:31:08 +0000 (22:31 +0200)]
Allow searching by email Message-ID

7 months agoRedirect straight to patch if search finds only one
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:29:32 +0000 (22:29 +0200)]
Redirect straight to patch if search finds only one

7 months agoAdd search bar to search page, so you can search again
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:29:02 +0000 (22:29 +0200)]
Add search bar to search page, so you can search again

7 months agoAdd instructions to checkout latest CFbot patchset
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:28:41 +0000 (22:28 +0200)]
Add instructions to checkout latest CFbot patchset

7 months agoAdd extra links to the patch page
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:28:18 +0000 (22:28 +0200)]
Add extra links to the patch page

7 months agoMake homepage more useful
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:28:01 +0000 (22:28 +0200)]
Make homepage more useful

A long list of ancient commitfests isn't super useful. This puts a few
links at the top of the page that cover the most common usages of the
commitfest app.

7 months agoAdd login redirect for dev environments
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:27:40 +0000 (22:27 +0200)]
Add login redirect for dev environments

7 months agoAdd a generic dev uwsgi script and update readme
Jelte Fennema-Nio [Tue, 24 Sep 2024 20:27:01 +0000 (22:27 +0200)]
Add a generic dev uwsgi script and update readme

8 months agoDon't crash on invalid target versions
Magnus Hagander [Mon, 5 Aug 2024 08:15:49 +0000 (10:15 +0200)]
Don't crash on invalid target versions

8 months agoAdd missing newline, breaking pycodestyle
Magnus Hagander [Mon, 5 Aug 2024 08:15:36 +0000 (10:15 +0200)]
Add missing newline, breaking pycodestyle

8 months agoAdd a stable URL for a patch that redirects to latest cf
Jelte Fennema-Nio [Mon, 24 Jun 2024 20:33:42 +0000 (22:33 +0200)]
Add a stable URL for a patch that redirects to latest cf

Links to patches get outdated ever time we move it to new commitfest.

8 months agoAdd /current link that links to either /inprogress or /open
Jelte Fennema-Nio [Sat, 22 Jun 2024 11:17:23 +0000 (13:17 +0200)]
Add /current link that links to either /inprogress or /open

8 months agoRedirect /open fully
Jelte Fennema-Nio [Sat, 22 Jun 2024 10:54:17 +0000 (12:54 +0200)]
Redirect /open fully

Now it forwards everything after the slash so that links like the
following work:

/open/new/
/open?author=-3

11 months agoUpdate url matching for django 4.2
Magnus Hagander [Wed, 8 May 2024 15:39:22 +0000 (17:39 +0200)]
Update url matching for django 4.2

11 months agoUpdate auth plugin with signal config for django 4.2
Magnus Hagander [Wed, 8 May 2024 15:39:12 +0000 (17:39 +0200)]
Update auth plugin with signal config for django 4.2

22 months agoSync up to latest version of pgweb auth plugin
Magnus Hagander [Wed, 7 Jun 2023 20:21:48 +0000 (22:21 +0200)]
Sync up to latest version of pgweb auth plugin

22 months agoDon't crash on missing parameter
Magnus Hagander [Wed, 7 Jun 2023 19:08:11 +0000 (21:08 +0200)]
Don't crash on missing parameter

2 years agoChange static->media and stop using collectstatic
Magnus Hagander [Wed, 12 Apr 2023 11:42:58 +0000 (13:42 +0200)]
Change static->media and stop using collectstatic

This changes both the storage location of the files and the URL. This
aligns it up with how (almost) all our other django apps work, so good
for consistency.

2 years agoHttp404 is an exception to raise, not a class to return
Magnus Hagander [Tue, 21 Feb 2023 17:19:54 +0000 (18:19 +0100)]
Http404 is an exception to raise, not a class to return

2 years agoRestrict user search/import to cf admins
Magnus Hagander [Tue, 21 Feb 2023 14:19:01 +0000 (15:19 +0100)]
Restrict user search/import to cf admins

All users can still enumerate local users, but the functionality to
search the central database is restricted to admins only.

Reported by Benjamin Flesch

2 years agoSwitch out pep8 for pycodestyle in git hook
Magnus Hagander [Tue, 21 Feb 2023 14:18:42 +0000 (15:18 +0100)]
Switch out pep8 for pycodestyle in git hook

New name for the same command.

3 years agoUpdate README and development requirements
Andreas Scherbaum [Tue, 25 Jan 2022 17:01:46 +0000 (18:01 +0100)]
Update README and development requirements

3 years agoUpdate for django 3.2 compatibility
Magnus Hagander [Sun, 12 Dec 2021 14:08:40 +0000 (15:08 +0100)]
Update for django 3.2 compatibility

3 years agoSilence pep8 warnings
Magnus Hagander [Thu, 25 Nov 2021 12:31:39 +0000 (13:31 +0100)]
Silence pep8 warnings

3 years agoReplace django-selectable with selectize
Magnus Hagander [Thu, 25 Nov 2021 12:30:28 +0000 (13:30 +0100)]
Replace django-selectable with selectize

django-selectable is no longer maintained, and will cause issues in
newer versions of django.

selectize is what we use in the pgeu-system codebase today, so copy the
handling over from there.

3 years agoProperly allow moving of WoA patches to next CF
Magnus Hagander [Mon, 4 Oct 2021 12:55:14 +0000 (14:55 +0200)]
Properly allow moving of WoA patches to next CF

The previous commit removed the refusal, but missed adding the allwing..

3 years agoAllow moving of Waiting On Author patches to next CF
Magnus Hagander [Mon, 4 Oct 2021 10:00:28 +0000 (12:00 +0200)]
Allow moving of Waiting On Author patches to next CF

Discussion: https://postgr.es/m/20211001173131.GA13090@ahch-to

4 years agoProperly escape list of messages when creating a new entry
Magnus Hagander [Tue, 8 Dec 2020 15:32:04 +0000 (16:32 +0100)]
Properly escape list of messages when creating a new entry

This has been broken since day 1... oops.

Noted by Vik Fearing

4 years agoRemove unused import
Magnus Hagander [Tue, 8 Dec 2020 15:31:38 +0000 (16:31 +0100)]
Remove unused import

4 years agoMove handling of secondary email addresses upstream
Magnus Hagander [Tue, 11 Aug 2020 11:14:55 +0000 (13:14 +0200)]
Move handling of secondary email addresses upstream

Since the upstream main website now handles secondary email addresses,
centralize the handling to there. This removes the local handling
completely, except that we store them in the database. The new
push-changes API ensures that they are kept in sync with upstream.

4 years agoImport latest version of community authentication plugin
Magnus Hagander [Tue, 11 Aug 2020 11:17:30 +0000 (13:17 +0200)]
Import latest version of community authentication plugin

This includes now accepting push changes from upstream.

5 years agoAnother django 2.2 update
Magnus Hagander [Fri, 10 Apr 2020 16:19:15 +0000 (18:19 +0200)]
Another django 2.2 update

5 years agoUpdates for django 2.2
Magnus Hagander [Wed, 1 Apr 2020 19:29:07 +0000 (21:29 +0200)]
Updates for django 2.2

5 years agoUpdate to latest version of django-selectable
Magnus Hagander [Wed, 1 Apr 2020 19:21:11 +0000 (21:21 +0200)]
Update to latest version of django-selectable

5 years agoSet on_delete=models.CASCADE on all relations
Magnus Hagander [Wed, 1 Apr 2020 19:12:55 +0000 (21:12 +0200)]
Set on_delete=models.CASCADE on all relations

5 years agoRemove unused file
Magnus Hagander [Wed, 1 Apr 2020 19:12:51 +0000 (21:12 +0200)]
Remove unused file

5 years agoUpdate favicon to match the main website, per Peter Eisentraut.
Jonathan S. Katz [Tue, 24 Mar 2020 09:13:32 +0000 (09:13 +0000)]
Update favicon to match the main website, per Peter Eisentraut.

5 years agoSync up community auth plugin to latest-and-greatest
Magnus Hagander [Wed, 26 Feb 2020 17:21:52 +0000 (18:21 +0100)]
Sync up community auth plugin to latest-and-greatest

6 years agoRemove reundant role attribute
Daniel Gustafsson [Wed, 27 Mar 2019 14:56:48 +0000 (15:56 +0100)]
Remove reundant role attribute

6 years agoDon't include "target version" on new patch form
Magnus Hagander [Thu, 28 Feb 2019 11:24:23 +0000 (12:24 +0100)]
Don't include "target version" on new patch form

6 years agoRemove trailing slashes from message-id URLs
Peter Eisentraut [Wed, 27 Feb 2019 09:36:32 +0000 (10:36 +0100)]
Remove trailing slashes from message-id URLs

This avoids useless redirects.

6 years agoChange backgroud color of target version label
Magnus Hagander [Sun, 10 Feb 2019 19:29:55 +0000 (20:29 +0100)]
Change backgroud color of target version label

Per request

6 years agoAnother markup fix
Daniel Gustafsson [Wed, 6 Feb 2019 20:47:14 +0000 (21:47 +0100)]
Another markup fix

6 years agoFix markup
Daniel Gustafsson [Wed, 6 Feb 2019 20:45:36 +0000 (21:45 +0100)]
Fix markup

6 years agoAdd index to patchhistory.date
Magnus Hagander [Wed, 6 Feb 2019 20:36:42 +0000 (21:36 +0100)]
Add index to patchhistory.date

6 years agoFix activity feed queries
Magnus Hagander [Wed, 6 Feb 2019 20:36:01 +0000 (21:36 +0100)]
Fix activity feed queries

These clearly had little to do with reality since they would return
duplicate entries if a patch was in more than one cf..

6 years agoAdd a field to each patch for target version
Magnus Hagander [Wed, 6 Feb 2019 20:05:06 +0000 (21:05 +0100)]
Add a field to each patch for target version

This is particularly interesting towards the end of a cycle where it can
be used to flag patches that are not intended for the current version
but still needs review.

6 years agoAdd a pre-commit hook to ensure pep8
Magnus Hagander [Wed, 6 Feb 2019 19:41:59 +0000 (20:41 +0100)]
Add a pre-commit hook to ensure pep8

6 years agoFix mail sender for py3
Magnus Hagander [Wed, 6 Feb 2019 19:25:40 +0000 (20:25 +0100)]
Fix mail sender for py3

6 years agoUpdate migrations for py3 unicode
Magnus Hagander [Wed, 6 Feb 2019 19:19:54 +0000 (20:19 +0100)]
Update migrations for py3 unicode

Need to change old migrations not to indicate we need new ones.

6 years agoUpdate cmd tools to use python3
Magnus Hagander [Wed, 6 Feb 2019 19:09:15 +0000 (20:09 +0100)]
Update cmd tools to use python3

This includes changing to requests for check_patches_in_archives.py,
like previously done for the internal APIs.

6 years agoRemove oneoff tool instead of having to port it
Magnus Hagander [Wed, 6 Feb 2019 19:03:12 +0000 (20:03 +0100)]
Remove oneoff tool instead of having to port it

6 years agoFix class property reference for py3
Magnus Hagander [Wed, 6 Feb 2019 18:58:48 +0000 (19:58 +0100)]
Fix class property reference for py3

6 years agoUnicode fixes for python 3
Magnus Hagander [Wed, 6 Feb 2019 18:42:47 +0000 (19:42 +0100)]
Unicode fixes for python 3

6 years agoImport latest, py3 compatible, auth.py
Magnus Hagander [Wed, 6 Feb 2019 19:01:20 +0000 (20:01 +0100)]
Import latest, py3 compatible, auth.py

6 years agoFix imports and exceptions for Python3
Magnus Hagander [Wed, 6 Feb 2019 18:40:45 +0000 (19:40 +0100)]
Fix imports and exceptions for Python3

6 years agoFixes for pep8 compatibility
Magnus Hagander [Tue, 5 Feb 2019 22:55:23 +0000 (23:55 +0100)]
Fixes for pep8 compatibility

6 years agoConvert all spaces to tabs
Magnus Hagander [Tue, 5 Feb 2019 22:01:05 +0000 (23:01 +0100)]
Convert all spaces to tabs

6 years agoSwitch to using requests for archives API
Magnus Hagander [Tue, 5 Feb 2019 21:56:05 +0000 (22:56 +0100)]
Switch to using requests for archives API

This should fix some unicode issues

6 years agoChange sort order for reviewers/authors in filter dropdown
Magnus Hagander [Wed, 26 Dec 2018 11:52:01 +0000 (12:52 +0100)]
Change sort order for reviewers/authors in filter dropdown

Previously it was sorted by last name, which did not always make sense.
Canged to sort by first name, which hopefully makes more sense.

Per request from Alvaro Herrera and others.

6 years agoAdd "withdrawn" commitfest status
Magnus Hagander [Sun, 23 Dec 2018 12:07:56 +0000 (13:07 +0100)]
Add "withdrawn" commitfest status

By popular (?) request

6 years agoMerge old model changes that never made it into migrations
Magnus Hagander [Sun, 23 Dec 2018 12:00:07 +0000 (13:00 +0100)]
Merge old model changes that never made it into migrations

6 years agoClarify some buttons
Andreas Scherbaum [Mon, 26 Nov 2018 12:46:57 +0000 (13:46 +0100)]
Clarify some buttons

Add some longer texts to indicate what's really hiding behind buttons.

6 years agoDon't use hardcoded pgsql-hackers name in status message
Andreas Scherbaum [Fri, 16 Nov 2018 13:20:03 +0000 (14:20 +0100)]
Don't use hardcoded pgsql-hackers name in status message

Instead use the value from the settings file, which is what's actually
used to send.

6 years agoInclude DKIM/SPF instructions on commit/review forms
Andreas Scherbaum [Fri, 16 Nov 2018 13:16:12 +0000 (14:16 +0100)]
Include DKIM/SPF instructions on commit/review forms

6 years agoClarify what subscribe/unsubscribe button does
Magnus Hagander [Sun, 4 Nov 2018 21:22:53 +0000 (22:22 +0100)]
Clarify what subscribe/unsubscribe button does

6 years agoAlso don't fail on invalid reviewers or authors
Magnus Hagander [Mon, 29 Oct 2018 11:48:35 +0000 (12:48 +0100)]
Also don't fail on invalid reviewers or authors

Same fix as the previous one for status, but applies to the other two
filter-by-dropdown fields.

6 years agoDon't fail on incorrect statuses in URL
Magnus Hagander [Sun, 16 Sep 2018 21:47:52 +0000 (23:47 +0200)]
Don't fail on incorrect statuses in URL

The comment said we should ignore the status if int() on it fails, but
to do that we have to fail it before we actually add the WHERE clause.
Thus, reorder the code to do so.

6 years agoFix colspan
Daniel Gustafsson [Mon, 18 Jun 2018 09:28:06 +0000 (11:28 +0200)]
Fix colspan

6 years agoBring back topic listing
Magnus Hagander [Tue, 29 May 2018 19:35:18 +0000 (15:35 -0400)]
Bring back topic listing

Accidentally broken when query was rewritten

6 years agoRewrite main CF dashboard query to use SQL
Magnus Hagander [Tue, 29 May 2018 19:28:35 +0000 (15:28 -0400)]
Rewrite main CF dashboard query to use SQL

We've long gone past what the django ORM can handle and got into
hundreds of queries for large commitfests. And it's not really that hard
to rewrite as SQL, even though we have to dynamically build the WHERE
clauses. So do that.

6 years agoShow the number of CFs a patch has been on
Magnus Hagander [Tue, 29 May 2018 18:25:12 +0000 (14:25 -0400)]
Show the number of CFs a patch has been on

Per discussions at the developer meeting, show the number of CFs a patch
has been on, and make it possible to sort on this value.

7 years agoDon't crash when passing in invalid values for filters
Magnus Hagander [Sun, 15 Apr 2018 12:49:13 +0000 (14:49 +0200)]
Don't crash when passing in invalid values for filters

Previously we'd throw a 500 internal server error, and cause error
logging to happen. This became evident when scripts trying to SQL-inject
the site started hitting us..

Instead, just ignore any filters that pass non-integer values into
integer fields completely.

7 years agoFix template loaders for django 1.11
Magnus Hagander [Sun, 25 Mar 2018 14:53:46 +0000 (16:53 +0200)]
Fix template loaders for django 1.11

Seems django 1.11 automatically enables caching template loader, which
of course breaks the ability to make any changes to the pages of a
website without restarting it. And there is no way to turn it off other
than to explicitly configure individual loders (the logic to turn it on
in non-debug configurations is hardcoded and cannot be changed).

7 years agoFix model diffing for django 1.11
Magnus Hagander [Thu, 22 Feb 2018 21:20:14 +0000 (22:20 +0100)]
Fix model diffing for django 1.11

7 years agoDon't allow null wikilink and gitlink
Magnus Hagander [Thu, 22 Feb 2018 21:19:46 +0000 (22:19 +0100)]
Don't allow null wikilink and gitlink

Both had a default set to '', so also put that in the model. Needed to
give correct diffs in newer djangos

7 years agoUpgrade django-selectable to v1.1.0
Magnus Hagander [Wed, 21 Feb 2018 21:05:18 +0000 (22:05 +0100)]
Upgrade django-selectable to v1.1.0

Needed for newer django

7 years agoFix warning triggered in django 1.11
Magnus Hagander [Wed, 21 Feb 2018 18:57:50 +0000 (19:57 +0100)]
Fix warning triggered in django 1.11

7 years agoImplement thread notification receiving
Magnus Hagander [Wed, 21 Feb 2018 17:31:54 +0000 (18:31 +0100)]
Implement thread notification receiving

This allows the archivs server to ping the CF app to pick up updates to
mailthreads quicker.

7 years agoUpdate format of urls.py to be compatible with newer django
Magnus Hagander [Wed, 21 Feb 2018 17:32:35 +0000 (18:32 +0100)]
Update format of urls.py to be compatible with newer django

7 years agoReplace render_to_response with render
Magnus Hagander [Wed, 21 Feb 2018 17:27:49 +0000 (18:27 +0100)]
Replace render_to_response with render

This is rquired as part of the move to a newer Django, and works fine on
older versions too

7 years agoFix template comparison operators
Magnus Hagander [Wed, 21 Feb 2018 17:34:02 +0000 (18:34 +0100)]
Fix template comparison operators

7 years agoUpdate template configuration syntax
Magnus Hagander [Wed, 21 Feb 2018 17:33:45 +0000 (18:33 +0100)]
Update template configuration syntax

Change to syntax compatible with newer Django, still works on current
version.

7 years agoActually deliver CCed emails to patch authors
Magnus Hagander [Sat, 20 Jan 2018 13:19:35 +0000 (14:19 +0100)]
Actually deliver CCed emails to patch authors

Previously we would set the Cc header of the email, but not actually
send a copy to the user. That way if the user was not subscribed to the
hackers email, they'd end up not receiving the email at all, which
somewhat defeats one of the original points of adding the Cc in the
first place.

Spotted by Peter Geoghegan

7 years agoUpdate README file
Pierre Giraud [Wed, 22 Nov 2017 19:08:31 +0000 (20:08 +0100)]
Update README file

While at it, convert to Markdown format for nicer rendering.

7 years agoFix typo
Daniel Gustafsson [Mon, 2 Oct 2017 08:02:44 +0000 (10:02 +0200)]
Fix typo

7 years agoHide annotation button if user is not logged in
Daniel Gustafsson [Mon, 18 Sep 2017 19:27:51 +0000 (21:27 +0200)]
Hide annotation button if user is not logged in

Reported by Peter Geoghegan

7 years agoFix typo
Daniel Gustafsson [Tue, 5 Sep 2017 23:19:39 +0000 (16:19 -0700)]
Fix typo

7 years agoFix closing of <table> tag
Daniel Gustafsson [Mon, 4 Sep 2017 10:38:24 +0000 (12:38 +0200)]
Fix closing of <table> tag

7 years agoFix incorrect reference to global templates directory
Magnus Hagander [Mon, 28 Aug 2017 10:59:30 +0000 (12:59 +0200)]
Fix incorrect reference to global templates directory

This has probably been needed since an upgrade a long time ago but got
stuck in a separate branch. Fixes the case where the admin interface
could end up rendering a login form that would then not work, instead of
providing the proper redirect.

7 years agoRemove deprecated and superfluous <script> attributes
Daniel Gustafsson [Tue, 27 Jun 2017 20:19:17 +0000 (22:19 +0200)]
Remove deprecated and superfluous <script> attributes

The language attribute has been deprecated for quite some time with
the type attribute setting the type of embedded content.  The type
attribute has further been defined to text/javascript as the default
value in the spec, so no attribute should be used for Javascript.
Per the standard: https://www.w3.org/TR/html5/scripting-1.html

7 years agoFix broken markup in future commitfests
Daniel Gustafsson [Tue, 27 Jun 2017 20:16:49 +0000 (22:16 +0200)]
Fix broken markup in future commitfests