From 4a4ee0c2c1e53401924101945ac3d517c0a8a559 Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Sat, 10 May 2025 07:36:27 -0700 Subject: [PATCH] Remove GLOBALTABLESPACE_OID assert for locked buffers. Commit f4ece891fc2f3f96f0571720a1ae30db8030681b added the assertion in an attempt to catch some defects even after VACUUM FULL or REINDEX. However, IsCatalogTextUniqueIndexOid(tag.relNumber) always returns false after a relfilenode change, provoking unintended assertion failures. Reported-by: Adam Guo Reviewed-by: Masahiko Sawada Bug: #18912 Discussion: https://postgr.es/m/18912-a41c9bd0e0ad19b1@postgresql.org --- src/backend/storage/buffer/bufmgr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 0b317d2d809..f93131a645e 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -4161,8 +4161,6 @@ AssertNotCatalogBufferLock(LWLock *lock, LWLockMode mode, return; Assert(!IsCatalogRelationOid(relid)); - /* Shared rels are always catalogs: detect even after VACUUM FULL. */ - Assert(tag.spcOid != GLOBALTABLESPACE_OID); } #endif -- 2.39.5