From 2f5b05620330baed1648a1a6e2f231c7ba1368d1 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 27 Apr 2025 16:58:57 -0400 Subject: [PATCH] Remove inappropriate inclusions of c.h and postgres_fe.h. Per our usual policy, Postgres header files should not include these; the decision as to which one to use is to be made in the calling .c file instead. These errors aren't particularly new, but I'm not feeling a need to back-patch these changes; it's mostly just neatnik-ism. --- src/bin/pg_combinebackup/copy_file.h | 1 - src/include/fe_utils/option_utils.h | 2 -- src/include/fe_utils/query_utils.h | 2 -- 3 files changed, 5 deletions(-) diff --git a/src/bin/pg_combinebackup/copy_file.h b/src/bin/pg_combinebackup/copy_file.h index 5a8517629c7..3779edd5677 100644 --- a/src/bin/pg_combinebackup/copy_file.h +++ b/src/bin/pg_combinebackup/copy_file.h @@ -11,7 +11,6 @@ #ifndef COPY_FILE_H #define COPY_FILE_H -#include "c.h" #include "common/checksum_helper.h" /* diff --git a/src/include/fe_utils/option_utils.h b/src/include/fe_utils/option_utils.h index 82c093df996..4504bbb36a8 100644 --- a/src/include/fe_utils/option_utils.h +++ b/src/include/fe_utils/option_utils.h @@ -12,8 +12,6 @@ #ifndef OPTION_UTILS_H #define OPTION_UTILS_H -#include "postgres_fe.h" - #include "common/file_utils.h" typedef void (*help_handler) (const char *progname); diff --git a/src/include/fe_utils/query_utils.h b/src/include/fe_utils/query_utils.h index 42e911d720a..4d7f7d60573 100644 --- a/src/include/fe_utils/query_utils.h +++ b/src/include/fe_utils/query_utils.h @@ -12,8 +12,6 @@ #ifndef QUERY_UTILS_H #define QUERY_UTILS_H -#include "postgres_fe.h" - #include "libpq-fe.h" extern PGresult *executeQuery(PGconn *conn, const char *query, bool echo); -- 2.30.2