From 1e314847dd69c6b3b85d36e5873d80b9e4cf028a Mon Sep 17 00:00:00 2001 From: Michael Paquier <michael@paquier.xyz> Date: Sat, 26 Nov 2022 20:12:33 +0900 Subject: [PATCH] Mark two signal flags as sig_atomic_t in pgbench and pg_test_fsync Two booleans used for timeout tracking were used within some SIGALRM signal handlers, but they were not declared as sig_atomic_t, so mark them as such. This has no consequence on WIN32 for both tools. Author: Ranier Vilela Reviewed-by: Michael Paquier, Masahiko Sawada Discussion: https://postgr.es/m/CAEudQArCDQQiPiFR16=yu9k5s2tp4tgEe1U1ZbkW4ofx81AWWQ@mail.gmail.com --- src/bin/pg_test_fsync/pg_test_fsync.c | 2 +- src/bin/pgbench/pgbench.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_test_fsync/pg_test_fsync.c b/src/bin/pg_test_fsync/pg_test_fsync.c index 5f8cbb75ffd..3d5e8f30ab7 100644 --- a/src/bin/pg_test_fsync/pg_test_fsync.c +++ b/src/bin/pg_test_fsync/pg_test_fsync.c @@ -68,7 +68,7 @@ static char full_buf[DEFAULT_XLOG_SEG_SIZE], *filename = FSYNC_FILENAME; static struct timeval start_t, stop_t; -static bool alarm_triggered = false; +static sig_atomic_t alarm_triggered = false; static void handle_args(int argc, char *argv[]); diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c index 36905a89681..ee1a33c9ee8 100644 --- a/src/bin/pgbench/pgbench.c +++ b/src/bin/pgbench/pgbench.c @@ -310,7 +310,7 @@ const char *progname; #define WSEP '@' /* weight separator */ -volatile bool timer_exceeded = false; /* flag from signal handler */ +volatile sig_atomic_t timer_exceeded = false; /* flag from signal handler */ /* * We don't want to allocate variables one by one; for efficiency, add a -- 2.39.5