From: Daniel Gustafsson Date: Fri, 8 Mar 2024 21:53:06 +0000 (+0100) Subject: Fix errorhandling for reading from a pipe X-Git-Tag: REL_17_BETA1~703 X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=be41a9b0380778a07386208afbf3f41ba7286cf3;p=postgresql.git Fix errorhandling for reading from a pipe When reading a line from a pipe failed on no data being read, the errorhandling was erroneously logging with %m even thoug no error description is available for %m to print. This flaw accidentally introduced in 5c7038d70bb. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/baa34329-f431-46af-bf74-1a78fdc90e4f@eisentraut.org --- diff --git a/src/common/exec.c b/src/common/exec.c index bcd5b71101e..0bee19c1e53 100644 --- a/src/common/exec.c +++ b/src/common/exec.c @@ -393,8 +393,8 @@ pipe_read_line(char *cmd) log_error(errcode_for_file_access(), _("could not read from command \"%s\": %m"), cmd); else - log_error(errcode_for_file_access(), - _("no data was returned by command \"%s\": %m"), cmd); + log_error(errcode(ERRCODE_NO_DATA), + _("no data was returned by command \"%s\""), cmd); } (void) pclose_check(pipe_cmd);