From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 3 Nov 2010 17:42:14 +0000 (-0400)
Subject: Reduce recursion depth in recently-added regression test.
X-Git-Tag: REL8_3_13~22
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=75991cb471ed4e624c6d7511c0373e28ce3195b2;p=postgresql.git

Reduce recursion depth in recently-added regression test.

Some buildfarm members fail the test with the original depth of 10 levels,
apparently because they are running at the minimum max_stack_depth setting
of 100kB and using ~ 10k per recursion level.  While it might be
interesting to try to figure out why they're eating so much stack, it isn't
likely that any fix for that would be back-patchable.  So just change the
test to recurse only 5 levels.  The extra levels don't prove anything
correctness-wise anyway.
---

diff --git a/src/test/regress/expected/plpgsql.out b/src/test/regress/expected/plpgsql.out
index a6ba6ab1b06..9b3b02a6a68 100644
--- a/src/test/regress/expected/plpgsql.out
+++ b/src/test/regress/expected/plpgsql.out
@@ -3179,8 +3179,8 @@ DROP FUNCTION nonsimple_expr_test();
 create function recurse(float8) returns float8 as
 $$
 begin
-  if ($1 < 10) then
-    return sql_recurse($1 + 1);
+  if ($1 > 0) then
+    return sql_recurse($1 - 1);
   else
     return $1;
   end if;
@@ -3189,10 +3189,10 @@ $$ language plpgsql;
 -- "limit" is to prevent this from being inlined
 create function sql_recurse(float8) returns float8 as
 $$ select recurse($1) limit 1; $$ language sql;
-select recurse(0);
+select recurse(5);
  recurse 
 ---------
-      10
+       0
 (1 row)
 
 create function error1(text) returns text language sql as
diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql
index 00040ed55d5..ddd695dad1c 100644
--- a/src/test/regress/sql/plpgsql.sql
+++ b/src/test/regress/sql/plpgsql.sql
@@ -2631,8 +2631,8 @@ DROP FUNCTION nonsimple_expr_test();
 create function recurse(float8) returns float8 as
 $$
 begin
-  if ($1 < 10) then
-    return sql_recurse($1 + 1);
+  if ($1 > 0) then
+    return sql_recurse($1 - 1);
   else
     return $1;
   end if;
@@ -2643,7 +2643,7 @@ $$ language plpgsql;
 create function sql_recurse(float8) returns float8 as
 $$ select recurse($1) limit 1; $$ language sql;
 
-select recurse(0);
+select recurse(5);
 
 create function error1(text) returns text language sql as
 $$ SELECT relname::text FROM pg_class c WHERE c.oid = $1::regclass $$;