From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 24 Mar 2024 16:13:35 +0000 (-0400)
Subject: Release temporary array in check_for_data_types_usage().
X-Git-Tag: REL_17_BETA1~543
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=225e1dde463ae312714d71a929f45cfd153df2be;p=postgresql.git

Release temporary array in check_for_data_types_usage().

Coverity identified this as a resource leak.  It's surely of no
consequence given that the function is called only once per run, but
freeing the storage is no more work than dismissing the complaint.
Minor oversight in commit 347758b12.
---

diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index c198896c9f0..fe73ec4f00b 100644
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -521,6 +521,8 @@ check_for_data_types_usage(ClusterInfo *cluster, DataTypesUsageChecks * checks)
 	if (found)
 		pg_fatal("Data type checks failed: %s", report.data);
 
+	pg_free(results);
+
 	check_ok();
 }