Address stats export review comments.

Per discussion, did not use Jian He's patch exactly.

Reported-by: jian he <[email protected]>
Reviewed-by: Corey Huinker <[email protected]>
Discussion: https://postgr.es/m/CACJufxFVq=tq9u1zrHWYSbMi1T07gS9Ff0LJScMco4HZmtZ1xw@mail.gmail.com
Discussion: https://postgr.es/m/CADkLM=f1n2_Vomq0gKab7xdxDHmJGgn=DE48P8fzQOp3Mrs1Qg@mail.gmail.com

diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
index 632077113a4a53448dd10f1aa968535eccad1334..7480e122b61f2aee4134533e138606851a34516f 100644 (file)
--- a/src/bin/pg_dump/pg_backup_archiver.c
+++ b/src/bin/pg_dump/pg_backup_archiver.c
@@ -2936,8 +2936,8 @@ _tocEntryRequired(TocEntry *te, teSection curSection, ArchiveHandle *AH)
        {
                if (!ropt->dumpStatistics)
                        return 0;
-               else
-                       res = REQ_STATS;
+
+               res = REQ_STATS;
        }
 
        /*
@@ -2984,10 +2984,6 @@ _tocEntryRequired(TocEntry *te, teSection curSection, ArchiveHandle *AH)
        if (ropt->no_subscriptions && strcmp(te->desc, "SUBSCRIPTION") == 0)
                return 0;
 
-       /* If it's statistics and we don't want statistics, maybe ignore it */
-       if (!ropt->dumpStatistics && strcmp(te->desc, "STATISTICS DATA") == 0)
-               return 0;
-
        /* Ignore it if section is not to be dumped/restored */
        switch (curSection)
        {