Disable tests using injection points in installcheck

The 'gin' test injections faults to GIN index build. If another test
running concurrently in the same cluster also tries to create a GIN
index, it will hit the fault, too.

To fix, disable tests using injection points when running against an
existing cluster. A better long-term solution would be to make the
injection points scoped to the database or process, but this will do
for now.

Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%[email protected]
Discussion: https://www.postgresql.org/message-id/10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi

diff --git a/src/test/modules/gin/Makefile b/src/test/modules/gin/Makefile
index a7731b7fa18cc21cfbbd8f87270339e74d241a8d..81ca6bfe35a50781372248a453f45cd6d7939fd2 100644 (file)
--- a/src/test/modules/gin/Makefile
+++ b/src/test/modules/gin/Makefile
@@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points
 
 REGRESS = gin_incomplete_splits
 
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)

diff --git a/src/test/modules/gin/meson.build b/src/test/modules/gin/meson.build
index 9734b51de2d4b0dd6ec6c7e4b778b445a3b41df5..5ec0760a276740073ea03f1d5c1768ed83dfbe95 100644 (file)
--- a/src/test/modules/gin/meson.build
+++ b/src/test/modules/gin/meson.build
@@ -12,5 +12,7 @@ tests += {
     'sql': [
       'gin_incomplete_splits',
     ],
+    # The injection points are cluster-wide, so disable installcheck
+    'runningcheck': false,
   },
 }

diff --git a/src/test/modules/injection_points/Makefile b/src/test/modules/injection_points/Makefile
index 2cbbae4e0a0ddf0fd2b7b6ce1d8707c6e8829c42..4248671513a5b644abcdf37995dd0b80697e9bde 100644 (file)
--- a/src/test/modules/injection_points/Makefile
+++ b/src/test/modules/injection_points/Makefile
@@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"
 
 REGRESS = injection_points
 
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)

diff --git a/src/test/modules/injection_points/meson.build b/src/test/modules/injection_points/meson.build
index ee37573f2abe1bde322cd1fbccaa1edec516c352..a29217f75f904ac1f960af1e4012113bf303281f 100644 (file)
--- a/src/test/modules/injection_points/meson.build
+++ b/src/test/modules/injection_points/meson.build
@@ -33,5 +33,7 @@ tests += {
     'sql': [
       'injection_points',
     ],
+    # The injection points are cluster-wide, so disable installcheck
+    'runningcheck': false,
   },
 }