Remove extra check_stack_depth() from dropconstraint_internal()

The second check was added by d57b7cc33 without taking into account there
is already a check since b0f7dd915.

Reported-by: Ashutosh Bapat, Alexander Lakhin
Discussion: https://postgr.es/m/CAExHW5sBZWDjeBUFs_ehEDM%2BuhWxTiBkPbLiat7ZjWkb-DWQWw%40mail.gmail.com

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 679dee10da400d5d0be96644915d373b82e1125d..f79879455636e1cc5bfe600a9145e646c526e5aa 100644 (file)
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -12738,9 +12738,6 @@ dropconstraint_internal(Relation rel, HeapTuple constraintTup, DropBehavior beha
    /* Guard against stack overflow due to overly deep inheritance tree. */
    check_stack_depth();
 
-   /* since this function recurses, it could be driven to stack overflow */
-   check_stack_depth();
-
    /* At top level, permission check was done in ATPrepCmd, else do it */
    if (recursing)
        ATSimplePermissions(AT_DropConstraint, rel, ATT_TABLE | ATT_FOREIGN_TABLE);