Fix another warning, introduced by 846311051e.

Discussion: https://postgr.es/m/3703896.1710799495@sss.pgh.pa.us
Reported-by: Tom Lane

diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
index f793f50b98444297ade6ebd19f99f7b0ecbfa69f..3f311e99076e376e4d907e63ff60646a2d481a0e 100644 (file)
--- a/src/backend/utils/adt/pg_locale.c
+++ b/src/backend/utils/adt/pg_locale.c
@@ -2505,13 +2505,13 @@ pg_strnxfrm_prefix(char *dest, size_t destsize, const char *src,
 int
 builtin_locale_encoding(const char *locale)
 {
-   if (strcmp(locale, "C") == 0)
-       return -1;
-   else
+   if (strcmp(locale, "C") != 0)
        ereport(ERROR,
                (errcode(ERRCODE_WRONG_OBJECT_TYPE),
                 errmsg("invalid locale name \"%s\" for builtin provider",
                        locale)));
+
+   return -1;
 }