pg_createsubscriber: Message style improvements

Refactor some messages, improve quoting.

diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c
index 028410323356ff025fc7396ece915ec4bb62345b..b02318782a66d3363502882d1180c7d02210dec0 100644 (file)
--- a/src/bin/pg_basebackup/pg_createsubscriber.c
+++ b/src/bin/pg_basebackup/pg_createsubscriber.c
@@ -897,8 +897,8 @@ check_publisher(const struct LogicalRepInfo *dbinfo)
    {
        pg_log_error("publisher requires %d replication slots, but only %d remain",
                     num_dbs, max_repslots - cur_repslots);
-       pg_log_error_hint("Consider increasing max_replication_slots to at least %d.",
-                         cur_repslots + num_dbs);
+       pg_log_error_hint("Increase the configuration parameter \"%s\" to at least %d.",
+                         "max_replication_slots", cur_repslots + num_dbs);
        failed = true;
    }
 
@@ -906,8 +906,8 @@ check_publisher(const struct LogicalRepInfo *dbinfo)
    {
        pg_log_error("publisher requires %d wal sender processes, but only %d remain",
                     num_dbs, max_walsenders - cur_walsenders);
-       pg_log_error_hint("Consider increasing max_wal_senders to at least %d.",
-                         cur_walsenders + num_dbs);
+       pg_log_error_hint("Increase the configuration parameter \"%s\" to at least %d.",
+                         "max_wal_senders", cur_walsenders + num_dbs);
        failed = true;
    }
 
@@ -1003,8 +1003,8 @@ check_subscriber(const struct LogicalRepInfo *dbinfo)
    {
        pg_log_error("subscriber requires %d replication slots, but only %d remain",
                     num_dbs, max_repslots);
-       pg_log_error_hint("Consider increasing max_replication_slots to at least %d.",
-                         num_dbs);
+       pg_log_error_hint("Increase the configuration parameter \"%s\" to at least %d.",
+                         "max_replication_slots", num_dbs);
        failed = true;
    }
 
@@ -1012,8 +1012,8 @@ check_subscriber(const struct LogicalRepInfo *dbinfo)
    {
        pg_log_error("subscriber requires %d logical replication workers, but only %d remain",
                     num_dbs, max_lrworkers);
-       pg_log_error_hint("Consider increasing max_logical_replication_workers to at least %d.",
-                         num_dbs);
+       pg_log_error_hint("Increase the configuration parameter \"%s\" to at least %d.",
+                         "max_logical_replication_workers", num_dbs);
        failed = true;
    }
 
@@ -1021,8 +1021,8 @@ check_subscriber(const struct LogicalRepInfo *dbinfo)
    {
        pg_log_error("subscriber requires %d worker processes, but only %d remain",
                     num_dbs + 1, max_wprocs);
-       pg_log_error_hint("Consider increasing max_worker_processes to at least %d.",
-                         num_dbs + 1);
+       pg_log_error_hint("Increase the configuration parameter \"%s\" to at least %d.",
+                         "max_worker_processes", num_dbs + 1);
        failed = true;
    }