Bound waits in 035_standby_logical_decoding.pl.

One IPC::Run::start() used an IPC::Run::timer() without checking for
expiration.  The other used no timeout or timer.  Back-patch to v16,
which introduced the test.

Reviewed by Bertrand Drouvot.

Discussion: https://postgr.es/m/20240211010227[email protected]

diff --git a/src/test/recovery/t/035_standby_logical_decoding.pl b/src/test/recovery/t/035_standby_logical_decoding.pl
index cebfa52d0fcd5ab59ac7380cbbcb01741b667bcd..b020361b297486d979c1e18673e7179fb648a9e8 100644 (file)
--- a/src/test/recovery/t/035_standby_logical_decoding.pl
+++ b/src/test/recovery/t/035_standby_logical_decoding.pl
@@ -21,7 +21,6 @@ my $node_cascading_standby =
   PostgreSQL::Test::Cluster->new('cascading_standby');
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
 my $default_timeout = $PostgreSQL::Test::Utils::timeout_default;
-my $psql_timeout = IPC::Run::timer($default_timeout);
 my $res;
 
 # Name for the physical slot on primary
@@ -90,7 +89,8 @@ sub make_slot_active
        '>',
        $to_stdout,
        '2>',
-       $to_stderr);
+       $to_stderr,
+       IPC::Run::timeout($default_timeout));
 
    if ($wait)
    {
@@ -341,7 +341,7 @@ $psql_subscriber{run} = IPC::Run::start(
    \$psql_subscriber{subscriber_stdout},
    '2>',
    \$psql_subscriber{subscriber_stderr},
-   $psql_timeout);
+   IPC::Run::timeout($default_timeout));
 
 ##################################################
 # Test that logical decoding on the standby