pgstattuple: Fix failure with pgstathashindex() for partitioned indexes
authorMichael Paquier <[email protected]>
Tue, 19 Dec 2023 06:20:39 +0000 (15:20 +0900)
committerMichael Paquier <[email protected]>
Tue, 19 Dec 2023 06:20:39 +0000 (15:20 +0900)
commita8dd62ef4959141e410278fd68b3d1821e0bbbaa
tree9afddec15bc5e24cae6f6b270df09eeae37646ff
parentc8bc807cf8bc741c83bc74553326856affee5a4f
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes

As coded, the function relied on index_open() when opening an index
relation, allowing partitioned indexes to be processed by
pgstathashindex().  This was leading to a "could not open file" error
because partitioned indexes have no physical files, or to a crash with
an assertion failure (like on HEAD).

This issue is fixed by applying the same checks as the other stat
functions for indexes, with a lookup at both RELKIND_INDEX and the index
AM expected.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org
Backpatch-through: 12
contrib/pgstattuple/expected/pgstattuple.out
contrib/pgstattuple/pgstatindex.c
contrib/pgstattuple/sql/pgstattuple.sql