Unwind #if spaghetti in hmac_openssl.c a bit.
authorTom Lane <[email protected]>
Tue, 2 Apr 2024 14:41:37 +0000 (10:41 -0400)
committerTom Lane <[email protected]>
Tue, 2 Apr 2024 14:41:44 +0000 (10:41 -0400)
commit38698dd38e56b6de31545ac284e36feb00d413cb
tree8ac48219001252f8187731798bdc9303a8e9aae1
parentcafe1056558fe07cdc52b95205588fcd80870362
Unwind #if spaghetti in hmac_openssl.c a bit.

Make this code a little less confusing by defining a separate macro
that controls whether we'll use ResourceOwner facilities to track
the existence of a pg_hmac_ctx context.

The proximate reason to touch this is that since b8bff07da, we got
"unused function" warnings if building with older OpenSSL, because
the #if guards around the ResourceOwner wrapper function definitions
were different from those around the calls of those functions.
Pulling the ResourceOwner machinations outside of the #ifdef HAVE_xxx
guards fixes that and makes the code clearer too.

Discussion: https://postgr.es/m/1394271.1712016101@sss.pgh.pa.us
src/common/hmac_openssl.c