Age | Commit message (Collapse) | Author |
|
Instead use the value from the settings file, which is what's actually
used to send.
|
|
|
|
|
|
Same fix as the previous one for status, but applies to the other two
filter-by-dropdown fields.
|
|
The comment said we should ignore the status if int() on it fails, but
to do that we have to fail it before we actually add the WHERE clause.
Thus, reorder the code to do so.
|
|
|
|
Accidentally broken when query was rewritten
|
|
We've long gone past what the django ORM can handle and got into
hundreds of queries for large commitfests. And it's not really that hard
to rewrite as SQL, even though we have to dynamically build the WHERE
clauses. So do that.
|
|
Per discussions at the developer meeting, show the number of CFs a patch
has been on, and make it possible to sort on this value.
|
|
Previously we'd throw a 500 internal server error, and cause error
logging to happen. This became evident when scripts trying to SQL-inject
the site started hitting us..
Instead, just ignore any filters that pass non-integer values into
integer fields completely.
|
|
|
|
Both had a default set to '', so also put that in the model. Needed to
give correct diffs in newer djangos
|
|
|
|
This allows the archivs server to ping the CF app to pick up updates to
mailthreads quicker.
|
|
This is rquired as part of the move to a newer Django, and works fine on
older versions too
|
|
|
|
Previously we would set the Cc header of the email, but not actually
send a copy to the user. That way if the user was not subscribed to the
hackers email, they'd end up not receiving the email at all, which
somewhat defeats one of the original points of adding the Cc in the
first place.
Spotted by Peter Geoghegan
|
|
|
|
Reported by Peter Geoghegan
|
|
|
|
|
|
The language attribute has been deprecated for quite some time with
the type attribute setting the type of embedded content. The type
attribute has further been defined to text/javascript as the default
value in the spec, so no attribute should be used for Javascript.
Per the standard: https://www.w3.org/TR/html5/scripting-1.html
|
|
|
|
|
|
|
|
Patch in 2e41b31654b80aeb3e6037fc0b31422c951040c7 only handled From and
missed the ohher tields. To make this cleaner, move the escpaping code
into the UserWrapper class.
Reported by Dagfinn Ilmari Mannsåker, but not using his patch
|
|
|
|
We need to treat them as structured and escape only the name, not the
email part.
Reported by Dagfinn Ilmari Mannsåker
|
|
This changed back when we upgraded django, but this error path is
clearly very seldomly hit.
|
|
They go in different orders in the two, so fully specify them to make it
super clear.
|
|
|
|
This adds the Cc field when using the Review or the Comment function on
the website, and will add a list of all listed authors of the patch to
this. Should help people highlight it in their inboxes.
Suggested by José Luis Tallón
|
|
|
|
|
|
So a patch that's in "ready for committer" status remains there.
When doing this, also refuse to move any patches that are not either
"waiting for review" or "ready for committer". They will have to have
their existing status changed first, and then be moved.
|
|
|
|
Userprofiles aren't set for everbody, so catch a missing exception and
just ignore it since we know a user without a profile didn't specifically
ask to get notified (as that's stored in the profile).
|
|
This makes it possible to receive notifications (via email) when a patch
has been updated.
It's possible to subscribe to notifications on a specific patch. It is also
possible to set the user profile up so that one receives notifications for
all patches where one is author, reviewer or committer on.
Notifications are, of course, only sent when other people make modifications
to the entry.
|
|
Should've been done with the migration to django 1.8, but better late
than never...
|
|
|
|
Newer djangos give warnings about this...
|
|
Per request during Brussels developer meeting
|
|
As requested by Jim Nasby and Alvaro Herrera
|
|
|
|
Grouped by each contriubtor, show which patches this person is the
author and reviewer of, to compare how many of each people have.
|
|
|
|
|
|
Somehow this worked on 1.4, probably by accident
|
|
|
|
Avoids one import...
T#
|