Page MenuHomePhabricator
Differential D211152

Bug 1893013 - Removed browser.firefox-view.search.enabled preference. r=kcochrane
AbandonedPublic
Actions

Authored by sukhmeet2002 on May 22 2024, 7:43 AM.

Details

Reviewers
kcochrane
Group Reviewers
fxview-reviewers
Bugzilla Bug ID
1893013
Summary

The preference 'browser.firefox-view.search.enabled' was removed as it's no longer needed.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
SeverityLocationCodeMessage
Errortoolkit/modules/BrowserUtils.sys.mjs:1prettiereslint (Mozlint)
Unit
No Test Coverage

Event Timeline

sukhmeet2002 created this revision.May 22 2024, 7:43 AM
Herald added a project: secure-revision. · View Herald TranscriptMay 22 2024, 7:43 AM
Harbormaster completed remote builds in B662945: Diff 865307.May 22 2024, 7:43 AM
phab-bot published this revision for review.May 22 2024, 7:43 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: fxview-reviewers. · View Herald TranscriptMay 22 2024, 7:43 AM
reviewbot added a subscriber: reviewbot.May 22 2024, 8:00 AM

Code analysis found 1 defect in diff 865307:

  • 1 defect found by eslint (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 865307.

kcochrane requested changes to this revision.May 22 2024, 3:29 PM

Thanks for the patch! We need to remove the pref entirely though, not just disable it.

This revision now requires changes to proceed.May 22 2024, 3:29 PM
sukhmeet2002 requested review of this revision.May 23 2024, 11:16 AM
sukhmeet2002 updated this revision to Diff 866078.
sukhmeet2002 edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B663604: Diff 866078.May 23 2024, 11:16 AM
sukhmeet2002 added a child revision: D211353: Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane.May 23 2024, 11:17 AM
sukhmeet2002 abandoned this revision.May 23 2024, 2:18 PM
jsudiaman mentioned this in D211353: Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane.May 28 2024, 4:26 PM
kcochrane removed a child revision: D211353: Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane.May 31 2024, 2:07 PM

Revision Contents
Changeset List

PathSize
browser/
app/
profile/
2 lines
components/
firefoxview/
6 lines
tests/
browser/
2 lines
4 lines
2 lines
4 lines
toolkit/
modules/
1 line

Diff 866078

View Options

browser/app/profile/firefox.js

Loading...
View Options

browser/components/firefoxview/helpers.mjs

Loading...
View Options

browser/components/firefoxview/tests/browser/browser_history_firefoxview.js

Loading...
View Options

browser/components/firefoxview/tests/browser/browser_opentabs_search.js

Loading...
View Options

browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js

Loading...
View Options

browser/components/firefoxview/tests/browser/browser_syncedtabs_firefoxview.js

Loading...
View Options

toolkit/modules/BrowserUtils.sys.mjs

Loading...
Privacy · Cookies · Legal