Edit report at http://bugs.php.net/bug.php?id=53438&edit=1
ID: 53438 Updated by: [email protected] Reported by: alxndr+bugs dot php dot net at gmail dot com Summary: array_fill/array_fill_keys don't run constructors multiple times -Status: Open +Status: Bogus Type: Bug Package: Class/Object related Operating System: Ubuntu 10.10 PHP Version: 5.3.3 Block user comment: N Private report: N New Comment: Thank you for taking the time to write to us, but this is not a bug. Please double-check the documentation available at http://www.php.net/manual/ and the instructions on how to report a bug at http://bugs.php.net/how-to-report.php function parameters are evaluated before a function call. There's no implicit clone happening. All expected. Previous Comments: ------------------------------------------------------------------------ [2010-12-01 17:56:49] alxndr+bugs dot php dot net at gmail dot com Description: ------------ array_fill() and array_fill_keys() create arrays filled with the same value, with unique copies in each value. However if that value is a class, it appears that they are all referencing just one value. That is, modifying a value of an array created with array_fill/array_fill_keys will modify all the values if that value is a class. It is as if the new class construction occurs once, and the result is placed in all values of the array being created (whereas if the value were to be an integer, string, or array, each value in the created array would be independent of the others). Test script: --------------- $arr1 = array_fill( 0, 2, array('foo') ); print "\narr1 after array_fill() with array as a value:\n".print_r($arr1,true); array_push($arr1[0],'bar'); print "\narr1 after pushing a string onto the first of the arrays in it:\n".print_r($arr1,true); class Test { public $storage = array(); public function __construct($p=null) { $this->add($p); } public function add($p=null) { if ($p) $this->storage[] = $p; } } $arr2 = array_fill(0, 2, new Test('foo') ); print "\narr2 after array_fill() with new Test as a value:\n".print_r($arr2,true); $arr2[0]->add('bar'); print "\narr2 after adding to the first object in it:\n".print_r($arr2,true); Expected result: ---------------- arr1 after array_fill() with array as a value: Array ( [0] => Array ( [0] => foo ) [1] => Array ( [0] => foo ) ) arr1 after pushing a string onto the first of the arrays in it: Array ( [0] => Array ( [0] => foo [1] => bar ) [1] => Array ( [0] => foo ) ) arr2 after array_fill() with new Test as a value: Array ( [0] => Test Object ( [storage] => Array ( [0] => foo ) ) [1] => Test Object ( [storage] => Array ( [0] => foo ) ) ) arr2 after adding to the first object in it: Array ( [0] => Test Object ( [storage] => Array ( [0] => foo [1] => bar ) ) [1] => Test Object ( [storage] => Array ( [0] => foo ) ) ) Actual result: -------------- arr1 after array_fill() with array as a value: Array ( [0] => Array ( [0] => foo ) [1] => Array ( [0] => foo ) ) arr1 after pushing a string onto the first of the arrays in it: Array ( [0] => Array ( [0] => foo [1] => bar ) [1] => Array ( [0] => foo ) ) arr2 after array_fill() with new Test as a value: Array ( [0] => Test Object ( [storage] => Array ( [0] => foo ) ) [1] => Test Object ( [storage] => Array ( [0] => foo ) ) ) arr2 after adding to the first object in it: Array ( [0] => Test Object ( [storage] => Array ( [0] => foo [1] => bar ) ) [1] => Test Object ( [storage] => Array ( [0] => foo [1] => bar ) ) ) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=53438&edit=1
