Fix travis (shakacode#437)

* test stripping out poltergeist
* restrict test suite
* log versions
* make sure chrome is latest version

Author: Judahmeek

.travis.yml

@@ -2,7 +2,7 @@ language:
   - ruby
 rvm:
   - 2.4.1
-sudo: false
+sudo: true
 notifications:
   slack: shakacode:YvfXbuFMcFAHt6ZjABIs0KET
 addons:
@@ -17,18 +17,20 @@ env:
   global:
     - RAILS_ENV=test
     - CXX=g++-4.9
-before_install:
-  - mkdir $PWD/travis-phantomjs
-  - curl -sSL https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2 -o $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
-  - tar -xvf $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis-phantomjs
-  - export PATH=$PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH
 install:
   - bundle install
   - chromedriver-update
+  - wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
+  - sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
+  - sudo apt-get update
+  - sudo apt-get install google-chrome-stable
   - nvm install stable && nvm alias default stable
-  - npm install -g npm@5.3.x
+  - npm install -g npm@5.6.x
   - npm install -g yarn
+  - node --version
   - npm --version
+  - google-chrome --version
+  - chromedriver --version
   - yarn install
   - rake db:setup
 

spec/rails_helper.rb

@@ -7,7 +7,6 @@
 
 require "rspec/rails"
 require "capybara/rspec"
-require "capybara/poltergeist"
 require "capybara-screenshot/rspec"
 require "database_cleaner"
 
@@ -51,9 +50,7 @@
 
   default_driver = :selenium_chrome
 
-  supported_drivers = %i[ poltergeist poltergeist_errors_ok
-                          poltergeist_no_animations webkit
-                          selenium_chrome selenium_firefox selenium]
+  supported_drivers = %i[selenium_chrome selenium_firefox selenium]
   driver = ENV["DRIVER"].try(:to_sym) || default_driver
   Capybara.default_driver = driver
 
@@ -62,39 +59,6 @@
   end
 
   case driver
-  when :poltergeist, :poltergeist_errors_ok, :poltergeist_no_animations
-    basic_opts = {
-      window_size: [1300, 1800],
-      screen_size: [1400, 1900],
-      phantomjs_options: ["--load-images=no", "--ignore-ssl-errors=true"],
-      timeout: 180
-    }
-
-    Capybara.register_driver :poltergeist do |app|
-      Capybara::Poltergeist::Driver.new(app, basic_opts)
-    end
-
-    no_animation_opts = basic_opts.merge( # Leaving animations off, as a sleep was still needed.
-      extensions: ["#{Rails.root}/spec/support/phantomjs-disable-animations.js"]
-    )
-
-    Capybara.register_driver :poltergeist_no_animations do |app|
-      Capybara::Poltergeist::Driver.new(app, no_animation_opts)
-    end
-
-    Capybara.register_driver :poltergeist_errors_ok do |app|
-      Capybara::Poltergeist::Driver.new(app, no_animation_opts.merge(js_errors: false))
-    end
-    Capybara::Screenshot.register_driver(:poltergeist) do |js_driver, path|
-      js_driver.browser.save_screenshot(path)
-    end
-    Capybara::Screenshot.register_driver(:poltergeist_no_animations) do |js_driver, path|
-      js_driver.render(path, full: true)
-    end
-    Capybara::Screenshot.register_driver(:poltergeist_errors_ok) do |js_driver, path|
-      js_driver.render(path, full: true)
-    end
-
   when :selenium_chrome
     DriverRegistration.register_selenium_chrome
   when :selenium_firefox, :selenium

spec/spec_helper.rb

@@ -40,7 +40,7 @@
     # Show retry status in spec process
     config.verbose_retry = true
     # Try twice (retry once)
-    config.default_retry_count = 4
+    config.default_retry_count = 2
     # Only retry when Selenium raises Net::ReadTimeout
     # config.exceptions_to_retry = [Net::ReadTimeout]
   end